search

azogue / aiopvpc

Simple aio library to download Spanish electricity hourly prices (PVPC) from esios.ree.es
MIT License
41 stars 10 forks source link

Remove python upper limit #59

Closed cdce8p closed 1 year ago

cdce8p commented 1 year ago

An upper limit for python blocks any attempt to install and test this package for new python versions like 3.12. Even if it doesn't technically work with those yet.

The recommendation for the python pin is usually to only use a lower bound.

azogue commented 1 year ago

Hi @cdce8p, thanks for contributing!

The recommendation for the python pin is usually to only use a lower bound.

You're totally right 👌

That is a bad habit of mine 😓, derived from the use of poetry in much more complex projects in terms of dependencies, where there is no other choice but to narrow the python version to achieve a dependency solution; but that's not the case for this library 🤣

cdce8p commented 1 year ago

Thanks for the review! Would you mind releasing a new version. Would be awesome to be able to start testing it with Python 3.12 for Home Assistant. After all the first release candidate is scheduled for tomorrow.

azogue commented 1 year ago

Thanks for the review! Would you mind releasing a new version. Would be awesome to be able to start using it with Python 3.12. After all the first release candidate is scheduled for tomorrow.

I'm on it right now 🍻

azogue commented 1 year ago

It's done: https://github.com/azogue/aiopvpc/releases/tag/v4.2.2

Sorry I didn't see this PR before 🙈

cdce8p commented 1 year ago

Thanks! No worries. It's still early for 3.12.