azogue / psychrochart

A Python 3 library to make psychrometric charts and overlay information on them.
MIT License
100 stars 26 forks source link

Add labels to connectors #6

Closed shenzha closed 5 years ago

shenzha commented 5 years ago

Add labels to connectors to show in legends.

azogue commented 5 years ago

Hi @zhang-shen,

Thank you so much for contributing, much appreciated :)

Only one comment: looks like a copy of equation.py is also included in the MR :( Could you remove that last commit from the MR, so I can merge it?

Also, it would be awesome to include some example of this labelling of connectors :)

shenzha commented 5 years ago

Hi @zhang-shen,

Thank you so much for contributing, much appreciated :)

Only one comment: looks like a copy of equation.py is also included in the MR :( Could you remove that last commit from the MR, so I can merge it?

Also, it would be awesome to include some example of this labelling of connectors :)

Hello @azogue,

I have removed the redundant file and included the example with connector label in the Jupyter notebook (see the last cell).

Thank you

Shen

azogue commented 5 years ago

Thank you ;-)