azohra / shell-linter

A Github Action for ShellCheck
https://github.com/marketplace/actions/shell-linter
MIT License
66 stars 13 forks source link

Added support for shellcheck severity mode #10

Closed asadmansr closed 4 years ago

asadmansr commented 4 years ago
asadmansr commented 4 years ago

@Azbagheri, the tests are failing due to an older version of shellcheck in our testing pipelines. The action uses v0.7.0, but the shellcheck installed on the ubuntu image (in pr-workflow) is v0.4.6.

We'll need to update the pr-workflow

EDIT: I have updated shellcheck to the latest

Azbagheri commented 4 years ago

@asadmansr seems like severity option is not supported in the version of shellcheck that is currently used on Github Actions. This can affect our users when we merge the new release. We should make that clear for our users that if they need to use severity option, they also have to update the shellcheck version in their pipeline. If we have a script to do that, we can include that in our readme with a screen shot as to have to update the shellcheck version.

megastep commented 4 years ago

Hi, any reason this can't be merged in the main branch sometime soon? The action has been broken because of broken dependencies for weeks in this branch.

asadmansr commented 4 years ago

Hey @megastep, this PR is different from the fix. The fix has been released in the latest version of shell-linter. Please update your workflow with the following: uses: azohra/shell-linter@v0.3.0. For more information, please refer to https://github.com/azohra/shell-linter/issues/21

We do apologize for any inconvenience. This will no longer be an issue in the future, as we are in the midst of changing our release strategy. Thank you

megastep commented 4 years ago

I specifically need the severity mode feature though, so that is not an option for me.

asadmansr commented 4 years ago

@megastep we'll get it out asap and let you know