azohra / shell-linter

A Github Action for ShellCheck
https://github.com/marketplace/actions/shell-linter
MIT License
66 stars 13 forks source link

use premade image #51

Open atkinsonm opened 1 year ago

atkinsonm commented 1 year ago

Pull Request Checklist

Corresponding Issue

https://github.com/azohra/shell-linter/issues/52

Description of Change

Use an image that already includes shellcheck. This makes the action more portable.

Motivation and Context

I was previously having trouble using this action in my GitHub Enterprise Server environment, probably because my environment is more restrictive and did not allow the wget from https://github.com/koalaman/shellcheck. By referencing the image directly, the installation script becomes unnecessary.

Testing Steps

Tested this in my fork in our private GitHub Enterprise Server environment and was able to run the action successfully.

Risks

<ADD-RISKS-HERE>

Additional Information

<ADD-ADDITIONAL-INFORMATION-HERE>