search

azohra / shell-linter

A Github Action for ShellCheck
https://github.com/marketplace/actions/shell-linter
MIT License
66 stars 13 forks source link

Support scripts with no extension #8

Closed br0p0p closed 4 years ago

br0p0p commented 4 years ago

Hi,

It would be great if this could support scripts that don't have the .sh extension. To make sure a file is actually a shell script, the executable permission could be checked, or ensure the shebang exists (or both).

Azbagheri commented 4 years ago

Hi @bropOp,

Thanks for reaching out! We think that's a great idea and we look into it for the next release!

br0p0p commented 4 years ago

@Azbagheri would you accept a PR for this?

Azbagheri commented 4 years ago

@br0p0p Thank you so much for your interest! However, I've already started working on it and it'll be published very soon! :)

Azbagheri commented 4 years ago

@br0p0p hey, we just released the new version of the action!! Shell Linter v0.2.0 supports scripts with no extension. Enjoy!