search

azouaoui-med / react-pro-sidebar

React Pro Sidebar provides a set of components for creating high level and customizable side navigation
https://azouaoui-med.github.io/react-pro-sidebar/
MIT License
1.69k stars 414 forks source link

Updated class name from '&.active' to '&.ps-active' #211

Closed sakaxo closed 5 months ago

sakaxo commented 7 months ago

Description

This pull request addresses an issue with the active class name for the MenuItem component, as defined in the README file. The README suggests using [&.active] for styling, but after inspecting the added class name in the browser, it appears as "ps-active" instead of "active".

Type of change

-Changes Made:

Updated the class name from [&.active] to [&.ps-active] in the MenuItem styles. With this change, the defined styles for [&.ps-active] now take effect as expected.

Documentation Update:

Updated the README file to reflect the correct active class name as [&.ps-active]. It's important for everyone to be aware of this change when styling the MenuItem component.

Testing:

Confirmed the issue by inspecting the class name in the browser. Applied the fix and verified that the correct styles are now applied when the menu item is active.

Additional Notes:

No issue number was associated with this change as it is a small fix to align with the actual class name being applied in the code.

azouaoui-med commented 7 months ago

@sakaxo in this example the active class name is generated by the react router library other than that the developer can use utility classes to refer to the menu state (menuClasses.active)

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.