search

azproduction / lmd

LMD - JavaScript Module-Assembler for building better web applications :warning: Project is no longer supported :warning:
http://azproduction.ru/lmd/
MIT License
449 stars 27 forks source link

Ensure that the target file has been properly flushed before exit #155

Closed generalov closed 10 years ago

generalov commented 10 years ago

It seems this patch fixes the https://github.com/azproduction/grunt-lmd/issues/4 for me on Ubuntu.

azproduction commented 10 years ago

@generalov oh, thanks. I will merge this PR and try to get rid of onAllEnd.

generalov commented 10 years ago

Thanks. It seems to me that the promises here would all greatly simplified. But I decided not to change the architecture.

azproduction commented 10 years ago

@generalov agree with promises. I will add them in the future releases after closing issue 114.

azproduction commented 10 years ago

@generalov fixed, but without passing callback.

Can you please check this fix, by installing lmd from git git://github.com/azproduction/lmd.git#master to be sure that everything is ok on your computer before I release?

generalov commented 10 years ago

It works! just remove the console.log

iAdramelk commented 10 years ago

Worked for me too. (Mac OS X 10.9)

azproduction commented 10 years ago

console.log

It is great that you notice. Thanks.

azproduction commented 10 years ago

Fixed in lmd@1.10.25