search

azrafe7 / hxPako

pako ported to haxe, for cross-platform zlib functionality
MIT License
28 stars 3 forks source link

update to pako 1.0.10 #6

Open lublak opened 5 years ago

azrafe7 commented 5 years ago

Hey @lublak, thanks for the PR.

Unfortunately I don't have time to properly review this at the moment.

From a quick view I can see that the actual changes to code are minimal (related to dictionary).

For this to be a proper update to pako.js 1.0.10 all tests must be ported too (and double check all the "relevant" changes from 1.0.4 to 1.0.10 in the original lib are ported too - https://github.com/nodeca/pako/compare/1.0.4...master).

I was also waiting for the issue related to zlib latest store changes (level 0) to be addressed, but that could wait. :smile:

lublak commented 5 years ago

Hey @azrafe7 no problem 😃 Pako does not change allot only: src/pako/Inflate.hx

It adds an extra inflateSetDictionary to initialisation. (based on https://github.com/nodeca/pako/commit/44b15356e490c8156ae15f0e0460fd49c663d4f3)

Mostly they change some build files.

this pull request adds also license information to src/pako/zlib/ and also change the example directory (it should be in the main package)

Just some information for you 😄