azriel91 / autexousious

Main repository for Will -- 2.5D moddable action adventure game
https://azriel.im/will
Apache License 2.0
44 stars 3 forks source link

Parallelize `System` Tests #174

Open azriel91 opened 4 years ago

azriel91 commented 4 years ago

In GitLab by @azriel91 on Oct 5, 2019, 08:54

Many tests currently load textures, and in rendy#151, using rendy in multiple threads at the same time causes a segfault. Using a mutex slows down testing a lot.

We can speed the tests up by not loading textures for Systems that simply need an AssetId and some components, instead of using AutexousiousApplication::config_base() or AutexousiousApplication::game_base()

azriel91 commented 4 years ago

In GitLab by @azriel91 on Oct 22, 2019, 11:54

Simply changing run_isolated() calls to run() worked. Perhaps underlying libraries or drivers were fixed to no longer have issues with running the tests in parallel.

Deferring re-organization of loading code in tests to a later date.

azriel91 commented 4 years ago

In GitLab by @azriel91 on Oct 23, 2019, 09:40

unassigned @azriel91

azriel91 commented 4 years ago

In GitLab by @azriel91 on Nov 7, 2019, 11:53

Perhaps introduce environmental / configuration flags that the asset part loaders read. Then even with SpriteRefs exist, they may choose to not load SpriteRenderSequences.