Closed azriel91 closed 4 years ago
Assign me please!
Thanks! Oh by the way, re:derivative, there's https://github.com/mcarton/rust-derivative/issues/58. I don't mind if you choose to:
Oh and github shows clippy warnings inline, scroll down a bit on https://github.com/azriel91/autexousious/pull/215/files
clippy
may decide to not warn on proc-macro generated code -- haven't opened an issue there yet.
The question might be completely dumb. But how should i run clippy in order to have the same output ?
Think this should be it:
cargo +stable clippy --all
Running it twice in a row might not get you the warnings the second time (clippy needs the files to be recompiled), but if you change a file then running it again should give you the warnings :v:.
Much appreciated!
Well, it seems like it's done.
Should i fork a repo in order to create a PR ? Or i can just create a branch right here and create a PR ?
Let's go with forking :v:
Closed in #216 :rocket:.
Clippy warns on
#[derivative(Debug)]
for thematch_single_binding
lint (see https://github.com/mcarton/rust-derivative/issues/58), and a number of other cases.We should fix these, and at the end of the fix, the
clippy
job should be able to pass with-D warnings
.Full list of clippy warnings / output (wall of text)
```bash warning: this match could be written as a `let` statement --> crate/tracker/src/system/last_tracker_system.rs:38:1 | 38 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 38 | let Derivative = #[derivative(Debug)]; 39 | Derivative | warning: this match could be written as a `let` statement --> crate/asset_gfx_gen/src/colour_sprite_sheet_gen_data.rs:11:1 | 11 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 11 | let Derivative = #[derivative(Debug)]; 12 | Derivative | warning: this match could be written as a `let` statement --> crate/tracker/src/system/prev_tracker_system.rs:38:1 | 38 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 38 | let Derivative = #[derivative(Debug)]; 39 | Derivative | Checking debug_util_amethyst v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/debug_util_amethyst) Checking game_mode_selection_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_mode_selection_model) Checking network_mode_selection_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/network_mode_selection_model) Checking parent_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/parent_play) Checking game_play_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_play_model) Checking charge_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/charge_model) warning: this match could be written as a `let` statement --> crate/asset_model/src/loaded/slug_and_handle.rs:14:1 | 14 | #[derivative(Clone(bound = ""), Debug(bound = ""), PartialEq(bound = ""))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Clone(bound = ""), Debug(bound = ""), PartialEq(bound = ""))]; 15 | Derivative | Checking sequence_loading_spi v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sequence_loading_spi) Checking application_ui v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/application_ui) Checking object_status_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/object_status_play) Checking stdio_command_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/stdio_command_model) Checking game_stats_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_stats_model) warning: this match could be written as a `let` statement --> crate/application_robot/src/state/robot_state.rs:10:1 | 10 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 10 | let Derivative = #[derivative(Debug)]; 11 | Derivative | Checking kinematic_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/kinematic_model) Checking sequence_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sequence_model) Checking game_input_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_input_model) warning: this match could be written as a `let` statement --> crate/parent_play/src/system/child_entity_delete_system.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | Checking audio_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/audio_model) Checking mirrored_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/mirrored_model) Checking state_support v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/state_support) Checking asset_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/asset_loading) Checking loading_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/loading_model) Checking assets_test v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/assets_test) Checking game_mode_selection_ui v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_mode_selection_ui) Checking application_menu v0.1.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/application_menu) Checking audio_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/audio_loading) warning: this match could be written as a `let` statement --> crate/kinematic_model/src/config/position_init.rs:83:1 | 83 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 83 | let Derivative = #[derivative(Debug)]; 84 | Derivative | warning: this match could be written as a `let` statement --> crate/kinematic_model/src/config/scale_init.rs:27:1 | 27 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 27 | let Derivative = #[derivative(Debug)]; 28 | Derivative | warning: this match could be written as a `let` statement --> crate/kinematic_model/src/config/velocity_init.rs:58:1 | 58 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 58 | let Derivative = #[derivative(Debug)]; 59 | Derivative | warning: this match could be written as a `let` statement --> crate/mirrored_model/src/play/mirrored.rs:41:1 | 41 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 41 | let Derivative = #[derivative(Debug)]; 42 | Derivative | warning: this match could be written as a `let` statement --> crate/kinematic_model/src/play/position_z_as_y.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_model/src/loaded/sequence_end_transitions.rs:19:1 | 19 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 19 | let Derivative = #[derivative(Debug)]; 20 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_model/src/loaded/sequence_id.rs:29:1 | 29 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 29 | let Derivative = #[derivative(Debug)]; 30 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_model/src/loaded/sequence_id_mappings.rs:108:1 | 108 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 108 | let Derivative = #[derivative(Debug)]; 109 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_model/src/loaded/wait_sequence_handles.rs:22:1 | 22 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 22 | let Derivative = #[derivative(Debug)]; 23 | Derivative | Checking chase_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/chase_model) Checking kinematic_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/kinematic_loading) Checking sprite_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sprite_model) Checking collision_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/collision_model) Checking spawn_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/spawn_model) Checking audio_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/audio_play) Checking sequence_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sequence_play) Checking sequence_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sequence_loading) Checking collision_audio_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/collision_audio_loading) Checking ui_audio_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_audio_loading) warning: this match could be written as a `let` statement --> crate/game_input_model/src/config/controller_config.rs:12:1 | 12 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 12 | let Derivative = #[derivative(Debug)]; 13 | Derivative | warning: this match could be written as a `let` statement --> crate/game_input_model/src/play/button_input_controlled.rs:21:1 | 21 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 21 | let Derivative = #[derivative(Debug)]; 22 | Derivative | warning: this match could be written as a `let` statement --> crate/game_input_model/src/play/input_controlled.rs:27:1 | 27 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 27 | let Derivative = #[derivative(Debug)]; 28 | Derivative | warning: this match could be written as a `let` statement --> crate/game_input_model/src/play/normal_input_controlled.rs:31:1 | 31 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 31 | let Derivative = #[derivative(Debug)]; 32 | Derivative | warning: this match could be written as a `let` statement --> crate/game_input_model/src/play/shared_input_controlled.rs:21:1 | 21 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 21 | let Derivative = #[derivative(Debug)]; 22 | Derivative | Checking network_session_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/network_session_model) Checking asset_selection_model v0.1.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/asset_selection_model) Checking character_selection_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_selection_model) warning: this match could be written as a `let` statement --> crate/chase_model/src/play/chase_mode_stick.rs:19:1 | 19 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 19 | let Derivative = #[derivative(Debug)]; 20 | Derivative | Checking charge_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/charge_play) Checking chase_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/chase_play) warning: this match could be written as a `let` statement --> crate/audio_play/src/system/sequence_audio_play_system.rs:25:1 | 25 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 25 | let Derivative = #[derivative(Debug)]; 26 | Derivative | Checking spawn_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/spawn_loading) warning: this match could be written as a `let` statement --> crate/sequence_loading/src/wait_sequence_loader.rs:8:1 | 8 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 8 | let Derivative = #[derivative(Debug)]; 9 | Derivative | warning: this match could be written as a `let` statement --> crate/collision_audio_loading/src/system/collision_audio_loading_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/collision_audio_loading/src/system/collision_audio_loading_system.rs:38:1 | 38 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 38 | let Derivative = #[derivative(Debug)]; 39 | Derivative | Checking collision_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/collision_play) Checking collision_audio_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/collision_audio_play) Checking collision_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/collision_loading) warning: this match could be written as a `let` statement --> crate/ui_audio_loading/src/system/ui_audio_loading_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/sprite_model/src/loaded/sprite_render_sequence_handles.rs:20:1 | 20 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 20 | let Derivative = #[derivative(Debug)]; 21 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_audio_loading/src/system/ui_audio_loading_system.rs:38:1 | 38 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 38 | let Derivative = #[derivative(Debug)]; 39 | Derivative | Checking ui_model_spi v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_model_spi) Checking object_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/object_model) warning: this match could be written as a `let` statement --> crate/sequence_play/src/system/frame_component_update_system.rs:33:1 | 33 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 33 | let Derivative = #[derivative(Debug)]; 34 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_play/src/system/sequence_component_update_system.rs:30:1 | 30 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 30 | let Derivative = #[derivative(Debug)]; 31 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_play/src/system/sequence_end_transition_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_play/src/system/sequence_status_update_system.rs:32:1 | 32 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 32 | let Derivative = #[derivative(Debug)]; 33 | Derivative | warning: this match could be written as a `let` statement --> crate/sequence_play/src/system/sequence_update_system.rs:32:1 | 32 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 32 | let Derivative = #[derivative(Debug)]; 33 | Derivative | Checking background_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/background_model) Checking sprite_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sprite_play) warning: this match could be written as a `let` statement --> crate/charge_play/src/system/charge_increment_system.rs:14:1 | 14 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Debug)]; 15 | Derivative | warning: this match could be written as a `let` statement --> crate/charge_play/src/system/charge_initialize_delay_system.rs:20:1 | 20 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 20 | let Derivative = #[derivative(Debug)]; 21 | Derivative | warning: this match could be written as a `let` statement --> crate/charge_play/src/system/charge_initialize_detection_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: this match could be written as a `let` statement --> crate/charge_play/src/system/charge_retention_system.rs:14:1 | 14 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Debug)]; 15 | Derivative | warning: this match could be written as a `let` statement --> crate/charge_play/src/system/charge_usage_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | Checking sprite_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/sprite_loading) warning: this match could be written as a `let` statement --> crate/chase_play/src/system/stick_to_target_object_system.rs:19:1 | 19 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 19 | let Derivative = #[derivative(Debug)]; 20 | Derivative | Checking map_selection_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/map_selection_model) Checking session_host_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_host_model) Checking session_join_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_join_model) Checking session_lobby_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_lobby_model) Checking game_input v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_input) warning: this match could be written as a `let` statement --> crate/collision_play/src/system/collision_detection_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/collision_play/src/system/contact_detection_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/collision_play/src/system/hit_effect_system.rs:20:1 | 20 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 20 | let Derivative = #[derivative(Debug)]; 21 | Derivative | warning: this match could be written as a `let` statement --> crate/collision_play/src/system/hitting_effect_system.rs:20:1 | 20 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 20 | let Derivative = #[derivative(Debug)]; 21 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_model_spi/src/config/dimensions.rs:21:1 | 21 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 21 | let Derivative = #[derivative(Debug)]; 22 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_model_spi/src/loaded/widget_status_sequences.rs:22:1 | 22 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 22 | let Derivative = #[derivative(Debug)]; 23 | Derivative | Checking ui_label_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_label_model) Checking ui_model_spi_play v0.1.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_model_spi_play) warning: this match could be written as a `let` statement --> crate/sprite_play/src/system/sprite_scale_update_system.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | warning: this match could be written as a `let` statement --> crate/object_model/src/loaded/object.rs:12:1 | 12 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 12 | let Derivative = #[derivative(Debug)]; 13 | Derivative | warning: this function has too many arguments (8/7) --> crate/object_model/src/loaded/object.rs:11:40 | 11 | #[derive(Clone, Derivative, PartialEq, new)] | ^^^ | = note: `#[warn(clippy::too_many_arguments)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info) warning: this match could be written as a `let` statement --> crate/object_model/src/play/grounding.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | Checking map_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/map_model) Checking background_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/background_loading) Checking game_play_hud v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_play_hud) Checking energy_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/energy_model) warning: this match could be written as a `let` statement --> crate/sprite_loading/src/scale_sequence_loader.rs:8:1 | 8 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 8 | let Derivative = #[derivative(Debug)]; 9 | Derivative | warning: this match could be written as a `let` statement --> crate/sprite_loading/src/sprite_render_sequence_loader.rs:11:1 | 11 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 11 | let Derivative = #[derivative(Debug)]; 12 | Derivative | warning: this match could be written as a `let` statement --> crate/sprite_loading/src/tint_sequence_loader.rs:11:1 | 11 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 11 | let Derivative = #[derivative(Debug)]; 12 | Derivative | Checking test_object_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/test_object_model) warning: this match could be written as a `let` statement --> crate/game_input/src/system/game_input_to_control_input_system.rs:32:1 | 32 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 32 | let Derivative = #[derivative(Debug)]; 33 | Derivative | Checking session_host_ui_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_host_ui_play) warning: this match could be written as a `let` statement --> crate/game_input/src/system/input_to_game_input_system.rs:25:1 | 25 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 25 | let Derivative = #[derivative(Debug)]; 26 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_model_spi_play/src/ui_rectify_system_data.rs:10:1 | 10 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 10 | let Derivative = #[derivative(Debug)]; 11 | Derivative | Checking net_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/net_model) warning: this match could be written as a `let` statement --> crate/ui_label_model/src/config/ui_label.rs:60:1 | 60 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 60 | let Derivative = #[derivative(Debug)]; 61 | Derivative | warning: using `clone` on a `Copy` type --> crate/ui_label_model/src/config/ui_label.rs:118:25 | 118 | ui_text.align = self.align.clone(); | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.align` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: using `clone` on a `Copy` type --> crate/ui_label_model/src/config/ui_label.rs:119:29 | 119 | ui_text.line_mode = self.line_mode.clone(); | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.line_mode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Checking control_settings_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/control_settings_model) Checking session_lobby_ui_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_lobby_ui_model) Checking ui_menu_item_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_menu_item_model) Checking ui_form_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_form_model) Checking ui_button_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/ui_button_model) Checking map_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/map_play) Checking energy_prefab v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/energy_prefab) warning: this match could be written as a `let` statement --> crate/game_play_hud/src/prefab/cp_bar_prefab.rs:43:1 | 43 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 43 | let Derivative = #[derivative(Debug)]; 44 | Derivative | warning: this match could be written as a `let` statement --> crate/game_play_hud/src/prefab/hp_bar_prefab.rs:42:1 | 42 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 42 | let Derivative = #[derivative(Debug)]; 43 | Derivative | warning: this match could be written as a `let` statement --> crate/game_play_hud/src/system/cp_bar_update_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/game_play_hud/src/system/hp_bar_update_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | Checking camera_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/camera_play) Checking object_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/object_play) Checking map_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/map_loading) warning: this match could be written as a `let` statement --> crate/session_host_ui_play/src/system/session_status_host_ui_system.rs:22:1 | 22 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 22 | let Derivative = #[derivative(Debug)]; 23 | Derivative | Checking assets_built_in v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/assets_built_in) Checking energy_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/energy_loading) warning: this match could be written as a `let` statement --> crate/session_lobby_ui_model/src/loaded/session_code_label.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | warning: this match could be written as a `let` statement --> crate/session_lobby_ui_model/src/loaded/session_devices_widget.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | Checking net_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/net_play) Checking network_session_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/network_session_play) warning: this match could be written as a `let` statement --> crate/ui_menu_item_model/src/loaded/ui_menu.rs:29:1 | 29 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 29 | let Derivative = #[derivative(Debug)]; 30 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_menu_item_model/src/loaded/ui_menu_item.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | Checking session_join_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_join_play) warning: this match could be written as a `let` statement --> crate/ui_form_model/src/config/ui_text_input.rs:38:1 | 38 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 38 | let Derivative = #[derivative(Debug)]; 39 | Derivative | warning: this match could be written as a `let` statement --> crate/ui_form_model/src/loaded/ui_form.rs:22:1 | 22 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 22 | let Derivative = #[derivative(Debug)]; 23 | Derivative | Checking session_host_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_host_play) Checking network_input_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/network_input_play) warning: this match could be written as a `let` statement --> crate/energy_prefab/src/system_data/energy_component_storages.rs:14:1 | 14 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Debug)]; 15 | Derivative | Checking session_lobby_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_lobby_play) warning: this match could be written as a `let` statement --> crate/object_play/src/system/object_acceleration_system.rs:25:1 | 25 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 25 | let Derivative = #[derivative(Debug)]; 26 | Derivative | warning: this match could be written as a `let` statement --> crate/object_play/src/system/object_gravity_system.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | warning: this match could be written as a `let` statement --> crate/object_play/src/system/object_grounding_system.rs:17:1 | 17 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 17 | let Derivative = #[derivative(Debug)]; 18 | Derivative | warning: this match could be written as a `let` statement --> crate/object_play/src/system/object_mirroring_system.rs:15:1 | 15 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 15 | let Derivative = #[derivative(Debug)]; 16 | Derivative | warning: this match could be written as a `let` statement --> crate/map_play/src/map_spawner_resources.rs:10:1 | 10 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 10 | let Derivative = #[derivative(Debug)]; 11 | Derivative | warning: this match could be written as a `let` statement --> crate/map_play/src/system/keep_within_map_bounds_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/map_play/src/system/map_enter_exit_detection_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | Checking session_lobby_ui_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_lobby_ui_play) warning: this match could be written as a `let` statement --> crate/map_play/src/system/map_out_of_bounds_clock_augment_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/map_play/src/system/map_out_of_bounds_deletion_system.rs:14:1 | 14 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Debug)]; 15 | Derivative | warning: this match could be written as a `let` statement --> crate/map_play/src/system/map_spawn_out_of_bounds_detection_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | Checking input_reaction_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/input_reaction_model) Checking application_event v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/application_event) warning: this match could be written as a `let` statement --> crate/camera_play/src/camera_component_storages.rs:14:1 | 14 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 14 | let Derivative = #[derivative(Debug)]; 15 | Derivative | warning: this match could be written as a `let` statement --> crate/camera_play/src/camera_creator_resources.rs:13:1 | 13 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 13 | let Derivative = #[derivative(Debug)]; 14 | Derivative | warning: this match could be written as a `let` statement --> crate/camera_play/src/system/camera_tracking_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | warning: this match could be written as a `let` statement --> crate/camera_play/src/system/camera_velocity_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | Checking state_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/state_play) warning: this match could be written as a `let` statement --> crate/net_play/src/system/net_listener_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: this match could be written as a `let` statement --> crate/net_play/src/system/net_message_request_system.rs:26:1 | 26 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 26 | let Derivative = #[derivative(Debug)]; 27 | Derivative | warning: this match could be written as a `let` statement --> crate/network_session_play/src/system/session_input_resources_sync_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: this match could be written as a `let` statement --> crate/network_session_play/src/system/session_message_response_system.rs:27:1 | 27 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 27 | let Derivative = #[derivative(Debug)]; 28 | Derivative | warning: this match could be written as a `let` statement --> crate/network_session_play/src/system/session_status_notifier_system.rs:16:1 | 16 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 16 | let Derivative = #[derivative(Debug)]; 17 | Derivative | Checking session_server v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/app/session_server) warning: this match could be written as a `let` statement --> crate/session_join_play/src/system/session_join_request_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | warning: this match could be written as a `let` statement --> crate/session_join_play/src/system/session_join_response_system.rs:27:1 | 27 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 27 | let Derivative = #[derivative(Debug)]; 28 | Derivative | warning: this match could be written as a `let` statement --> crate/session_host_play/src/system/session_host_request_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | warning: this match could be written as a `let` statement --> crate/session_host_play/src/system/session_host_response_system.rs:27:1 | 27 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 27 | let Derivative = #[derivative(Debug)]; 28 | Derivative | warning: this match could be written as a `let` statement --> crate/network_input_play/src/system/network_input_request_system.rs:26:1 | 26 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 26 | let Derivative = #[derivative(Debug)]; 27 | Derivative | warning: this match could be written as a `let` statement --> crate/network_input_play/src/system/network_input_response_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/session_lobby_play/src/system/session_lobby_request_system.rs:23:1 | 23 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 23 | let Derivative = #[derivative(Debug)]; 24 | Derivative | warning: this match could be written as a `let` statement --> crate/session_lobby_play/src/system/session_lobby_response_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> crate/session_lobby_play/src/system/session_lobby_response_system.rs:54:48 | 54 | session_lobby_events.for_each(|ev| match ev { | ________________________________________________^ 55 | | NetData { 56 | | data: SessionLobbyEvent::SessionStartNotify, 57 | | .. ... | 63 | | _ => {} 64 | | }); | |_____________^ | = note: `#[warn(clippy::single_match)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try this | 54 | session_lobby_events.for_each(|ev| if let NetData { 55 | data: SessionLobbyEvent::SessionStartNotify, 56 | .. 57 | } = ev { 58 | debug!("Session start notification received."); 59 | ... warning: this match could be written as a `let` statement --> crate/session_lobby_ui_play/src/system/session_code_label_update_system.rs:16:1 | 16 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 16 | let Derivative = #[derivative(Debug)]; 17 | Derivative | warning: needlessly taken reference of both operands --> crate/session_lobby_ui_play/src/system/session_code_label_update_system.rs:42:36 | 42 | .filter(|(_, ui_text)| &ui_text.text != &session_code.0) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::op_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 42 | .filter(|(_, ui_text)| ui_text.text != session_code.0) | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ warning: this match could be written as a `let` statement --> crate/session_lobby_ui_play/src/system/session_device_entity_create_delete_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: this match could be written as a `let` statement --> crate/session_lobby_ui_play/src/system/session_device_widget_update_system.rs:16:1 | 16 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 16 | let Derivative = #[derivative(Debug)]; 17 | Derivative | Checking application_state v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/application_state) Checking stdio_spi v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/stdio_spi) Checking control_settings v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/control_settings) warning: this match could be written as a `let` statement --> crate/state_play/src/system/state_camera_reset_system.rs:21:1 | 21 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 21 | let Derivative = #[derivative(Debug)]; 22 | Derivative | warning: this match could be written as a `let` statement --> crate/state_play/src/system/state_id_event_system.rs:18:1 | 18 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 18 | let Derivative = #[derivative(Debug)]; 19 | Derivative | warning: this match could be written as a `let` statement --> crate/state_play/src/system/state_item_spawn_system.rs:24:1 | 24 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 24 | let Derivative = #[derivative(Debug)]; 25 | Derivative | warning: this match could be written as a `let` statement --> crate/state_play/src/system/state_item_ui_input_augment_system.rs:29:1 | 29 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 29 | let Derivative = #[derivative(Debug)]; 30 | Derivative | warning: this match could be written as a `let` statement --> app/session_server/src/system/network_input_responder_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: using `clone` on a `Copy` type --> app/session_server/src/system/network_input_responder_system.rs:105:29 | 105 | ... game_input_event.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*game_input_event` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy warning: this match could be written as a `let` statement --> app/session_server/src/system/session_device_disconnect_responder_system.rs:25:1 | 25 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 25 | let Derivative = #[derivative(Debug)]; 26 | Derivative | warning: this match could be written as a `let` statement --> app/session_server/src/system/session_host_responder_system.rs:36:1 | 36 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 36 | let Derivative = #[derivative(Debug)]; 37 | Derivative | warning: this match could be written as a `let` statement --> app/session_server/src/system/session_join_responder_system.rs:35:1 | 35 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 35 | let Derivative = #[derivative(Debug)]; 36 | Derivative | warning: this match could be written as a `let` statement --> app/session_server/src/system/session_lobby_responder_system.rs:28:1 | 28 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 28 | let Derivative = #[derivative(Debug)]; 29 | Derivative | warning: this match could be written as a `let` statement --> crate/input_reaction_model/src/play/basic_irr_system_data.rs:11:1 | 11 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 11 | let Derivative = #[derivative(Debug)]; 12 | Derivative | Checking character_model v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_model) Checking input_reaction_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/input_reaction_loading) warning: this match could be written as a `let` statement --> crate/application_state/src/app_state.rs:36:1 | 36 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 36 | let Derivative = #[derivative(Debug)]; 37 | Derivative | warning: this match could be written as a `let` statement --> crate/application_state/src/app_state.rs:188:1 | 188 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 188 | let Derivative = #[derivative(Debug)]; 189 | Derivative | Checking stdio_input v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/stdio_input) Checking network_mode_selection_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/network_mode_selection_stdio) Checking session_host_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_host_stdio) Checking game_input_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_input_stdio) Checking game_play_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_play_stdio) Checking game_mode_selection_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/game_mode_selection_stdio) Checking session_join_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/session_join_stdio) Checking asset_selection_stdio v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/asset_selection_stdio) Checking map_selection v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/map_selection) Checking character_selection v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_selection) warning: this match could be written as a `let` statement --> crate/input_reaction_loading/src/irs_loader_params.rs:7:1 | 7 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 7 | let Derivative = #[derivative(Debug)]; 8 | Derivative | warning: this match could be written as a `let` statement --> crate/character_model/src/play/character_irr_system_data.rs:17:1 | 17 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 17 | let Derivative = #[derivative(Debug)]; 18 | Derivative | Checking character_prefab v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_prefab) Checking character_play v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_play) Checking object_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/object_loading) Checking character_loading v0.18.0 (/mnt/data/work/gitlab/azriel91/autexousious/crate/character_loading) warning: this match could be written as a `let` statement --> crate/map_selection/src/map_selection_state.rs:54:1 | 54 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::match_single_binding)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 54 | let Derivative = #[derivative(Debug)]; 55 | Derivative | warning: this match could be written as a `let` statement --> crate/map_selection/src/system/map_selection_system.rs:25:1 | 25 | #[derivative(Debug)] | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding help: consider using `let` statement | 25 | let Derivative = #[derivative(Debug)]; 26 | Derivative | warning: the function has a cognitive complexity of (53/25) --> crate/stdio_input/src/ion/splitter.rs:173:8 | 173 | fn next(&mut self) -> Option