search

azriel91 / autexousious

Main repository for Will -- 2.5D moddable action adventure game
https://azriel.im/will
Apache License 2.0
44 stars 3 forks source link

Fix clippy #216

Closed Lighty0410 closed 4 years ago

Lighty0410 commented 4 years ago

There are couple of things i don't know how to handle:

1) crate/ui_model/src/config/ui_type.rs - line 27. SessionLobby(Box<SessionLobbyUi>) instead of SessionLobby(SessionLobbyUi). Since everything compiles (?) i'm not sure if it may break something. 2) crate/object_model/src/loaded/object.rs:11:40. Don't know how to handle.

And also splitter.rs was refactored due to cognitive complexity. Please, take a look.

Lighty0410 commented 4 years ago

Recheck please! args: -- -D warnings is being uncommented.

I have added early return statement in splitter.rs. Can you take a look on it ? There are tons of predicates and it's so easy to make a mistake :P