azriel91 commented 4 years ago

Closes #234, and re-enables WASM job on CI.

azriel91 commented 4 years ago

Coverage failure seems to be a re-occurrence of https://github.com/xd009642/tarpaulin/issues/487:

error: could not compile `wayland-commons`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
[ERROR tarpaulin] Failed to compile tests! Error: cannot find attribute `skip` in this scope
Error: "Failed to compile tests! Error: cannot find attribute `skip` in this scope"
##[error]Process completed with exit code 1.

WASM failure may be to do with rust nightly -- I think on a later nightly, backtrace is built in to libstd:

error: couldn't read /usr/share/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/../backtrace/src/lib.rs: No such file or directory (os error 2)
   --> /usr/share/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/lib.rs:518:1
    |
518 | mod backtrace_rs;
    | ^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: could not compile `std`.

azriel91 commented 4 years ago

Looks like for tarpaulin 0.14 to work, dependencies need to change #[cfg(tarpaulin, skip)] to #[cfg(not(tarpaulin_include))]. See https://github.com/xd009642/tarpaulin/issues/487#issuecomment-649075161. Shall use tarpaulin 0.13 for now.

codecov[bot] commented 4 years ago

Codecov Report

Merging #235 into master will decrease coverage by 0.39%. The diff coverage is 6.03%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   69.08%   68.69%   -0.40%     
==========================================
  Files         643      649       +6     
  Lines       21988    22109     +121     
==========================================
- Hits        15190    15187       -3     
- Misses       6798     6922     +124

Impacted Files	Coverage Δ
app/session_server/src/main.rs	`0.00% <0.00%> (ø)`
...session_server/src/model/game_input_tick_status.rs	`0.00% <0.00%> (ø)`
app/session_server/src/model/session_code_id.rs	`0.00% <0.00%> (ø)`
app/session_server/src/model/session_code_to_id.rs	`0.00% <0.00%> (ø)`
...ession_server/src/model/session_device_mappings.rs	`0.00% <0.00%> (ø)`
..._server/src/model/session_id_to_device_mappings.rs	`0.00% <0.00%> (ø)`
app/session_server/src/play/session_tracker.rs	`0.00% <0.00%> (ø)`
...erver/src/system/network_input_responder_system.rs	`0.00% <0.00%> (ø)`
app/session_server/src/system/session_cleaner.rs	`0.00% <0.00%> (ø)`
...stem/session_device_disconnect_responder_system.rs	`0.00% <0.00%> (ø)`
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22acec4...5dcccd4. Read the comment docs.

azriel91 / autexousious

Bugfix/234/hp and cp bar rendering #235

Codecov Report