Fix conditionals in get_storage_id

aztfmod / rover

The rover is a docker container in charge of the deployment of the Terraform platform engineering for Azure

MIT License

172 stars 142 forks source link

Closed brk3 closed 2 years ago

brk3 commented 2 years ago

The checks for missing storage account ids would never fire as 'null' is not a valid type in bash.

This resulted in an empty value for 'ids' being returned causing subsequent errors in the 'az' command (and possibly elsewhere).

Update these to the standard bash '-z' check. Also remove the check for null in functions.sh as this case is covered within get_storage_id.

Fixes aztfmod/rover/issues/207

arnaudlh commented 2 years ago

hi @brk3 thanks for your contribution to Cloud Adoption Framework for Azure! Moving to integration for October release.