aztfmod / rover

The rover is a docker container in charge of the deployment of the Terraform platform engineering for Azure
MIT License
171 stars 142 forks source link

Update to Microsoft Graph API Queries #245

Closed arnaudlh closed 2 years ago

arnaudlh commented 2 years ago

When running rover with latest Azure CLI, you get the following messages:

image

WARNING: The underlying Active Directory Graph API will be replaced by Microsoft Graph API in a future version of Azure CLI. Please carefully review all breaking changes introduced during this migration: https://docs.microsoft.com/cli/azure/microsoft-graph-migration

The cause is a set of queries in rover to locate objects, that are relying on Azure AD Graph API queries as such: image

az ad signed-in-user show --query userPrincipalName -o tsv

Purpose of this issue is to track the replacement of all the Azure AD Graph API to Microsoft Graph API if needed.

sharmilamusunuru commented 2 years ago

Hi Arnaud,

I have tested this query over azure betaCLI which is compatible with Microsoft Graph API, and below command is working fine, but show objectID is returning null. Ouput attached below.

(tutorial-env) C:\Users\smusunuru>azcli --version 'azcli' is not recognized as an internal or external command, operable program or batch file.

(tutorial-env) C:\Users\smusunuru>az --version azure-cli 2.34.1.post20220325082216

core 2.34.1.post20220325082216 telemetry 1.0.6.post20220325082216

Dependencies: msal 1.17.0 azure-mgmt-resource 20.0.0

Python location 'C:\Users\smusunuru\tutorial-env\Scripts\python.exe' Extensions directory 'C:\Users\smusunuru.azure\cliextensions'

Python (Windows) 3.10.4 (tags/v3.10.4:9d38120, Mar 23 2022, 23:13:41) [MSC v.1929 64 bit (AMD64)]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Please let us know how we are doing: https://aka.ms/azureclihats and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy

(tutorial-env) C:\Users\smusunuru>az ad signed-in-user show --query userPrincipalName -o tsv The underlying Active Directory Graph API will be replaced by Microsoft Graph API in Azure CLI 2.37.0. Please carefully review all breaking changes introduced during this migration: https://docs.microsoft.com/cli/azure/microsoft-graph-migration smusunuru@microsoft.com

(tutorial-env) C:\Users\smusunuru>az ad signed-in-user show --query objectId -o tsv The underlying Active Directory Graph API will be replaced by Microsoft Graph API in Azure CLI 2.37.0. Please carefully review all breaking changes introduced during this migration: https://docs.microsoft.com/cli/azure/microsoft-graph-migration