Rover v2 Implementation - Proposal

benc-uk commented 3 years ago

This issue is to discuss & provide feedback on the proposal for Rover v2, which is hosted on the wiki for easier editing

Note. This is a "living document" and constantly evolving

benc-uk commented 3 years ago

Agreements from meeting 3rd Jun

All authentication is deferred to the Azure CLI (and the auth token it maintains), env vars (e.g. ARM_CLIENT_ID) are not used except in the impersonation scenario
This will be a clean break and a v2 of rover CLI, it will not be backwards compatible, but some migration guide, i.e. mapping old command to new will be written
The landingzone and launchpad modes will be split into separate top level commands (as it currently is)
The rover cd command and use of a symphony YAML config is expected to be the main use case going forward
The rover launchpad and rover landingzone will be kept for people wishing to test locally and personas not doing devops (IT pros etc). The cd, launchpad and landingzone commands will all function on the same code under the hood, where they source their inputs from is all that differs (flags vs config file)

benc-uk commented 3 years ago

7th June

Agreed to move the --action flag to be a sub-command of launchpad, landingzone and cd
Agreed on symmetry between all three commands
Agreed CD should look for default config file name in current directory