rover lp destroy command line not parsing -c correctly

aztfmod / rovergo

The next version of Rover, the command line tool for Azure CAF Landingzones. Developed in Go

MIT License

10 stars 7 forks source link

rover lp destroy command line not parsing -c correctly #70

Closed sebastus closed 3 years ago

sebastus commented 3 years ago

When I tried this command with an incorrect -c parameter, the command tried to run anyway, gave incorrect results.

rover lp destroy -c $HOME/caf_config -s $HOME/git/caf-terraform-landingzones -l level0

I left off /demo/level0 from the -c parameter.

benc-uk commented 3 years ago

The implementation is naïve and doesn't check for the existence of the folder PLUS doesn't check if the folder contains any .tfvar files, those checks would probably fix this.

Of course there's no way to stop a user pointing it a folder filled with totally incorrect .tfvars and screwing things that way. But PEBCAK can't be avoided