aztfmod / rovergo

The next version of Rover, the command line tool for Azure CAF Landingzones. Developed in Go
MIT License
10 stars 7 forks source link

testdata: refactor #99

Closed sebastus closed 3 years ago

sebastus commented 3 years ago

Relocate pkg/testdata to /test/testdata Relocate existing pkg/*_test.go to /test Rename /samples to /examples Ensure configurations still work, (level0 & level1) whether from command line or debugging using launch.json in vs code.

Reasons

Notes / Considerations

Outcomes

benc-uk commented 3 years ago

I definitely think pkg/ should remain unpolluted of things like test data

If we're following the golang project structure https://github.com/golang-standards/project-layout and we loosely have been until now.

Then it should reside in a folder called test/ in root of the repo And if we follow that then samples/ should be renamed examples/

I don't think we need to worry about launch.json too much, I expect some people will use it, others will not

sebastus commented 3 years ago

Thanks for the reference. I'll include in the PR for this issue movement of existing test to conform to that standard. (amended above)

sebastus commented 3 years ago

resolved by #111