search

aztfmod / terraform-azurerm-caf

Terraform supermodule for the Terraform platform engineering for Azure
https://aztfmod.github.io/documentation/
MIT License
555 stars 702 forks source link

Owners not added to Azure AD groups #924

Open chris-p-martin opened 2 years ago

chris-p-martin commented 2 years ago

The functionality to add owners to Azure AD groups doesn't seem to be working.

I've implemented the changes to fix this in #923 .

This should allow owners to be added as outlined in the examples.

An alternative approach would be to change the owner variable to be a list as per other Azure AD objects in the module, such as Applications

For example, changing from this:

owners = { user_principal_names = ["12345678-1234-1234-1245-123456789012"] }

to this:

owners = ["12345678-1234-1234-1245-123456789012"]

chris-p-martin commented 2 years ago

Closed the pull request due to it also including another change I wish to incorporate,

I will re-raise the pull request shortly.

chris-martin2 commented 2 years ago

Opened pull request #925 for this issue