Correct slugs according to caf recommended abbreviations

aztfmod / terraform-provider-azurecaf

Terraform provider for the Terraform platform engineering for Azure

172 stars 91 forks source link

Correct slugs according to caf recommended abbreviations #188

Open t3mi opened 1 year ago

t3mi commented 1 year ago

Fixes #186, #168

PR Checklist

[x] I have read the CONTRIBUTING.MD instructions
[x] I have changed the resourceDefinition.json
[x] I have generated the resource model (there's a models_generated.go file in my PR)
[x] I have updated the README.md#resource-status
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[x] YES
[ ] NO

Testing

arnaudlh commented 1 year ago

Very good catches @t3mi - we will add it on next major update to avoid regression on already deployed resources!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

t3mi commented 1 year ago

Yeah, I've targeted 3_0 branch for the merge. If this isn't right please provide the correct target. Thanks!

carnei-ro commented 3 days ago

@arnaudlh , could this be part of the 2.0 release? Maybe generating a -preview4; I am considering using this provider, but I'd like to start CAF compliant