fix(resourceDefinition.json) allow underscores within azurerm_key_vault_secret

nusrath432 commented 2 years ago

Issue

[x] I have read the CONTRIBUTING.MD instructions
[x] I have changed the resourceDefinition.json
[ ] I have generated the resource model (there's a models_generated.go file in my PR)
[ ] I have updated the README.md#resource-status
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

allow underscores within azurerm_key_vault_secret

Needs testing

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
No Duplication information

arnaudlh commented 2 years ago

@nusrath432 underscores are not allowed for secrets as per: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftkeyvault so current implementation looks good, what do you think @Nepomuceno?

arnaudlh commented 2 years ago

Closing until further updates from @nusrath432 and @Nepomuceno

nusrath432 commented 1 year ago

@arnaudlh Request was from @wasfree - You are right, underscores are not allowed in KV - no action required - can close issue https://github.com/aztfmod/terraform-azurerm-caf/issues/950

nusrath432 commented 1 year ago