prompt gets turncated in wimenu with Xft font

aztrock / wmii

Automatically exported from code.google.com/p/wmii

MIT License

0 stars 0 forks source link

prompt gets turncated in wimenu with Xft font #177

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. use a Xft font in wmii 
     echo font xft:Monospace:pixelsize=10 | wmiir write /ctl
2. run wimenu with the prompt "||||||"
     echo test | wimenu -p "||||||"

What is the expected result? What do you see instead?
the prompt should show "||||||", but instead it shows "||..."

What version of the product are you using (wmii -v)? On what operating
system?
wmii-hg2600, linux with libXft-2.1.14

looks like there is an inconsistency between the textwidth and the
drawstring method. A simple workaround would be to add a little bit to
promptw in menu.c.
I did not find any other location in wmii where a text gets turncated.

Original issue reported on code.google.com by _w...@web.de on 6 Apr 2010 at 9:40

GoogleCodeExporter commented 9 years ago

here's the workaround, dunno if 2 pixel are enough for all fonts :/

Original comment by _w...@web.de on 6 Apr 2010 at 7:26

Attachments:

prompt-width.patch

GoogleCodeExporter commented 9 years ago

Fascinating...

Original comment by maglion...@gmail.com on 6 Apr 2010 at 7:53

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 931a509765.

Original comment by maglion...@gmail.com on 6 Apr 2010 at 7:53

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Hi Kris,

The changeset which fixed this bug has introduced another one:

cc: error.o: No such file or directory
make[2]: *** [wmii.out] Error 1
make[1]: *** [dall] Error 2
make: *** [dall] Error 2

This was caused by the following hunk:

     3.1 --- a/cmd/wmii/Makefile    Mon Jan 25 02:01:19 2010 -0500
     3.2 +++ b/cmd/wmii/Makefile    Tue Apr 06 15:53:33 2010 -0400
     3.3 @@ -18,6 +18,7 @@
     3.4    client  \
     3.5    column  \
     3.6    div \
     3.7 +  error   \
     3.8    event   \
     3.9    ewmh    \
    3.10    float   \

Please push another changeset that reverts the above hunk.  Thanks.

Original comment by sun...@gmail.com on 11 Apr 2010 at 4:02

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Anselm fixed the Makefile bug.  Closing this issue.

Original comment by sun...@gmail.com on 12 Apr 2010 at 8:56

Changed state: Fixed