Title feature #19 - Githubissues

azu / gitbook-plugin-include-codeblock

GitBook plugin for including file

Other

40 stars 25 forks source link

Title feature #19 #20

Closed gdolle closed 8 years ago

gdolle commented 8 years ago

Pull-request proposal for feature #19

Now the title is optional
Pass the option title to display the file name
Pass a value to this previous option title:"An example of custom title" to display a custom title.

Bug/Known issue:

Does not work properly if user write asciidoc pages. See issue #18. A workaround for now is to not pass any title, and create it directly in asciidoc. For example

.This is the title
[import](path/to/code.ext)

Possible improvment:

Add code caption numbering. (would be useful for pdf format for example).

azu commented 8 years ago

I've written another suggestion to https://github.com/azu/gitbook-plugin-include-codeblock/issues/19#issuecomment-217351006

gdolle commented 8 years ago

Code updated!

azu commented 8 years ago

@gdolle Thanks for huge update! 👍 I've reviewed it and I comments:

One question ❓ :
- https://github.com/azu/gitbook-plugin-include-codeblock/pull/20/files#r62426025
Need to update 🔔 :
- https://github.com/azu/gitbook-plugin-include-codeblock/pull/20/files#r62426040
- https://github.com/azu/gitbook-plugin-include-codeblock/pull/20/files#r62426110
Other is small things

gdolle commented 8 years ago

Thanks for your comments. Code updated!

azu commented 8 years ago

It looks good :)

prudhomm commented 8 years ago

@azu @gdolle any news on the merging of this PR ?

prudhomm commented 8 years ago

titles are broken and don't look good. Could it be possible to merge this PR and upload a new version of this plugin ? see here http://book.feelpp.org/content/Tutorial/02-SettingUpEnvironment.html thx in advance

azu commented 8 years ago

I wait for updateing https://github.com/azu/gitbook-plugin-include-codeblock/pull/20#discussion_r62426040

titles are broken and don't look good.

Hmm, Do you use Asciidoc? https://github.com/feelpp/feelpp-book/blob/master/Tutorial/02-SettingUpEnvironment.adoc

Previously, gitbook-plugin-include-codeblock supported only markdown, but this pull request including support asciidoc. If it will merge, resolve your issue.

azu commented 8 years ago

OK. I've merged it. I will release new version as soon as. But it contain breaking change, I will release as 2.0.0-beta #22

prudhomm commented 8 years ago

@azu yes we use asciidoc. should the imported code be colorized (c++) automatically actually ? it does not seem to work but may be I haven't tested/used enough

gdolle commented 8 years ago

should the imported code be colorized (c++) automatically actually

@prudhomm See issue #21. Not fixed yet ;)

azu commented 8 years ago

@prudhomm I've released https://github.com/azu/gitbook-plugin-include-codeblock/releases/tag/1.9.0 Please try it. ( #21 is not fixed yet. )