azu / gitbook-plugin-include-codeblock

GitBook plugin for including file
Other
40 stars 25 forks source link

### markers don't work #33

Closed aslakhellesoy closed 7 years ago

aslakhellesoy commented 7 years ago

According to the docs, ### should be a valid comment in front of a marker.

That's currently not the case - the marker is not found.

azu commented 7 years ago

fmm. This feature is implemented by @gdolle . After merge this feature and I've tweak docs.

Docs is wrong or Feature is missing?

jcodeing commented 7 years ago

Markers do not work I downloaded the example found that the operation can not be normal markers Help

gdolle commented 7 years ago

Actually it should work from ##. I guess I did not include that case while proposing the pull request. But just adding the character # here ( so [\*!\/#]) should solve the problem. @azu can you make the change ?

azu commented 7 years ago

Thanks for confirm. Welcome to PR :)

azu commented 7 years ago

This is resolved by https://github.com/azu/gitbook-plugin-include-codeblock/releases/tag/2.2.0 and close it