Allow using of non-word characters in [import] tag

azu / gitbook-plugin-include-codeblock

GitBook plugin for including file

Other

40 stars 25 forks source link

Allow using of non-word characters in [import] tag #52

Closed lwchkg closed 7 years ago

lwchkg commented 7 years ago

Parsing algorithm redone to allow proper parsing of title:"edit:true" or the like. (edit should not be set to true in this case).
More validity check for the input is done.
Added relevant tests.

Known problems:

Cannot parse title:"he's good" properly. In this patch the title we be set to "he".
Output escaping is not done (but HandleBar HTML escapes all {{}} tags.) This breaks Nunjucks (in your ace templates) if the last character of the string is exactly \.

lwchkg commented 7 years ago

Please take a look (I've missed by a day, since there are a lot to read from different packages). There are still two issues to solve, so please advice whether I should ask them here or to put them in another PR.

BTW, some GitBook dependencies appears to be broken in the CI. :-(

lwchkg commented 7 years ago

Found that the build failure is due to a bug in gitbook-cli 2.3.1. See https://github.com/GitbookIO/gitbook-cli/issues/68 for the bug report.

azu commented 7 years ago

I think it's better that adding pattern test to https://github.com/azu/gitbook-plugin-include-codeblock/tree/master/test/patterns

lwchkg commented 7 years ago

Thanks for pointing out at the pattern test. I'll add a few there.

lwchkg commented 7 years ago

The new patch is finally prepared. Please take a look.

To resolve failures in CI, I've blacklisted "gitbook-cli" 2.3.1 in the example/*/package.json.

azu commented 7 years ago

LGTM

azu commented 7 years ago

@lwchkg Thanks!

azu commented 7 years ago

Release 3.1.1