How to change highlight color

crystalfp commented 4 years ago

Issue Type: Bug

Thanks for this extension! I would like to ask how to change the color of the highlight. Currently it is yellow, but with a dark theme the white text is invisible.

Extension version: 1.2.3 VS Code version: Code 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a, 2020-10-13T15:06:15.712Z) OS version: Windows_NT x64 10.0.19042

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|31.74GB (16.56GB free)| |Process Argv|--file-uri file:///d%3A/Montessori/Libro%20-%20Tecnologia%20in%20famiglia/Tecnologia%20in%20famiglia.code-workspace| |Screen Reader|no| |VM|0%|

azu commented 4 years ago

https://github.com/azu/vscode-read-aloud-text/blob/2e3a0ad4f0eca4c19845ce8025e980d841e902cf/src/extension.ts#L23-L37 Currently, backgroundColor is hardcoded yellow. We can use another color in dark mode, Which color is best?

crystalfp commented 4 years ago

Maybe yellow, but dark. In a quick test I have tried this: #747245

azu / vscode-read-aloud-text

How to change highlight color #5