azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.1k stars 112 forks source link

[FEAT]: Add support for paths, in the DNS blocklist sources #102

Open Serph91P opened 11 months ago

Serph91P commented 11 months ago

Feature Description

Like the Titel says, would be great if you could add them from a space or , seperated list. For the sake of easyness ;)

azukaar commented 10 months ago

Thanks for the ticket! Could you provide more details, please? Which URL Blocking are you referring to exactly?

Serph91P commented 10 months ago

Thanks for the ticket! Could you provide more details, please? Which URL Blocking are you referring to exactly?

Here you can add url with lists to block at the DNS option at constellation. ATM you have to add them one by one. At Poole for example you can add them from a space.seperated list. Like this url1 url2 url3 ... Would be great if this was possible here aswell.

azukaar commented 10 months ago

ahhh I see, Understood. I am not sure I would implement it this way because

I think the best way to maintain a long list of blocked URL is to create a text file, create a static URL to it in the reverse proxy, and then use that URL to add to the blocklist in the DNS config file (let me know if that explaination is not clear)

I will keep this ticket open, but with a different idea: add a path to the blocklist alongside URLs, so we could add files directly (if you think that it would solve the issue)

Serph91P commented 10 months ago

ahhh I see, Understood. I am not sure I would implement it this way because

  • It would be redudant with other existing tools (using a URL, using the list in the UI, and I think I kept the feature blacklist.txt at the root at the /config folder but not sure).
  • It would be difficult to manage more than 5-6 URLs this way in a small intput

I think the best way to maintain a long list of blocked URL is to create a text file, create a static URL to it in the reverse proxy, and then use that URL to add to the blocklist in the DNS config file (let me know if that explaination is not clear)

I will keep this ticket open, but with a different idea: add a path to the blocklist alongside URLs, so we could add files directly (if you think that it would solve the issue)

I get where you are going have you ever used pihole? There you can add multiple urls to files later used on the Blocklist ect. There you can input a space separated list of said urls like from here if you copy this and paste in pihole the all get added.

azukaar commented 10 months ago

OHH so you mean, you would have "URL1, URL2, URL3" you paste this in an input an it adds them as blocklist URL (the text files?) URL for the lists, not the URLs to block themselves right?

Serph91P commented 10 months ago

OHH so you mean, you would have "URL1, URL2, URL3" you paste this in an input an it adds them as blocklist URL (the text files?) URL for the lists, not the URLs to block themselves right?

Exactly