azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.45k stars 119 forks source link

[BUG]: Some Application Icons not load #140

Open pthoelken opened 10 months ago

pthoelken commented 10 months ago

What happened?

Some Application icons are not load after save the application. When I use the direct domain / ip as website address in a new tab, I can see the favicon.

Maybe there is a way to define the icons manually?

image

What should have happened?

All Icons should be loaded correctly.

How to reproduce the bug?

-

Relevant log output

No response

Other details

No response

System details

azukaar commented 10 months ago

I keep improving favicon loading the problem is, there is a hundred different ways to define them and some devs just use the most exotics syntax sometime... It's really difficult to end up with a solution that can load anything

For manual edit, yes it will be added soon

pthoelken commented 10 months ago

Thanks for the informations :)

bassista commented 7 months ago

I suggest grabbing the app icon this way: curl -sO https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons/png/${app_name}.png

I'm using this approach to feed cosmos with missing icons and I have always found the right icon on the first shot.

azukaar commented 7 months ago

I suggest grabbing the app icon this way: curl -sO https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons/png/${app_name}.png

I'm using this approach to feed cosmos with missing icons and I have always found the right icon on the first shot.

The issue is not with applications, it's with URLs themselves. Aka. fetch favicon on arbitrary URLs