azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.65k stars 130 forks source link

Added option to provide custom dns challenge resolvers #251

Open SamuelNitsche opened 6 months ago

SamuelNitsche commented 6 months ago

When installing Cosmos Server in internal networks using split dns, letsencrypt dns challenges will most likely fail since the local dns server is used as challenge resolver.

This PR updates the UI and backend to provide an (optional) dns server which is used to resolve the dns challenge. If the user does not enter a custom server, it will just fall back to the local dns server configured on the machine. Users can also provide multiple servers by separating them using a comma.

Closes https://github.com/azukaar/Cosmos-Server/issues/43

cla-bot[bot] commented 6 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

cla-bot[bot] commented 6 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

azukaar commented 3 months ago

Thanks! (and sorry for the delay reviewing it) This looks good but shouldnt the input only appear if the DNS Challenge is selected?