azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.65k stars 130 forks source link

Added depends_on with condition & fixed dependency reorder algorithm #302

Open tcorzo opened 3 months ago

tcorzo commented 3 months ago

This pull request adds support for unmarshal of the depends_on field with conditions. It also includes a fix for the dependency reorder algorithm. The changes allow direct import of compose files with dependency condition fields and fixes false positives regarding circular dependencies. The code has been tested with various scenarios and includes unit tests to verify the functionality. Notes:

cla-bot[bot] commented 3 months ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: tcorzo. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 3 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

tcorzo commented 3 months ago

Omg the conditions are already implemented on unstable 🤦‍♂️ I think the circular dependencies bug is still present though, I'll check