search

azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.65k stars 130 forks source link

Add config checkbox to show/hide redirect URLs on Homepage #307

Open orelgs opened 3 months ago

orelgs commented 3 months ago

This gives users more personalization for what is shown on the home page :)

cla-bot[bot] commented 3 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

azukaar commented 3 months ago

Thanks for the contribution! Upon reviewing there's an issue with the general idea: basically, I don't think a generic "show redirect" is enough for this. Instead, I think the check should be per-URL. There is already a "Hide from dashboard" option in URL, but the URLs that are redirect are ignored. I think the PR should make it so redirects URLs are not ignored, but "hide from dashboard" is true by default when creating a redirect I am just not exactly sure how to implement this because when you reach the form to create a URL, the ttoe gas bit been selected yet

cla-bot[bot] commented 3 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

orelgs commented 3 months ago

Thanks for the contribution! Upon reviewing there's an issue with the general idea: basically, I don't think a generic "show redirect" is enough for this. Instead, I think the check should be per-URL. There is already a "Hide from dashboard" option in URL, but the URLs that are redirect are ignored. I think the PR should make it so redirects URLs are not ignored, but "hide from dashboard" is true by default when creating a redirect I am just not exactly sure how to implement this because when you reach the form to create a URL, the ttoe gas bit been selected yet

I get what you're saying, then by this logic, changing the URL mode automatically decides the base value for HideFromDashboard, so I've implemented a simple onChange method for when a user changes the URL mode. Now HideFromDashboard is automatically selected / deselected depending on the mode (selected if mode is redirect), the user can change this afterwards. Also removed the auto-skip URL on homepage.

What do you say?

azukaar commented 3 months ago

Yes that looks better thanks! Could you remove the condition with the skip altogether? I dont think it will be required anymore since the value is always false then it should be ready to merge

cla-bot[bot] commented 3 months ago

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, add yourself to the .clabot file as contributor, as a way of signing the CLA.

orelgs commented 3 months ago

Yes that looks better thanks! Could you remove the condition with the skip altogether? I dont think it will be required anymore since the value is always false then it should be ready to merge

Done, is this what you meant?