azukaar / Cosmos-Server

☁️ The Most Secure and Easy Selfhosted Home Server. Take control of your data and privacy without sacrificing security and stability (Authentication, anti-DDOS, anti-bot)
https://cosmos-cloud.io
Other
3.13k stars 112 forks source link

[FEAT]: Allow the use of dash in username, and spaces in password #81

Closed C-Fu closed 1 year ago

C-Fu commented 1 year ago

Feature Description

Trying to name my user as C-Fu or c-fu results in an error:

Key: 'AdminJSON.Nickname' Error:Field validation for 'Nickname' failed on the 'alphanum' tag

Is there no way to use dash in the username?

Also I believe if I use password Issue Report it is more if not just as secure as 1ssu3Rep0rt. Just saying, as per xkcd's infamous comic strip.

azukaar commented 1 year ago

nickname is pure alpha numeric, no dash. The nickname has many uses and no garantee that all those uses will accept dashes that is why

For the password, I'm not sure I understand what you are trying to say? That Cosmos should not enforce password model? If yes, then that will not happen since it is important to ensure that password is strong since it controls everything, and people tend to be lazy when setting up password. Also not everything put in a comic is true, this is a good example of something that isn't