search

azukaar / cosmos-casaos-store

Conversion of the CasaOS app store for Cosmos
Apache License 2.0
17 stars 1 forks source link

FEAT:Route and Permissions Fix #2

Closed lilkidsuave closed 7 months ago

lilkidsuave commented 7 months ago

Auto Configured Route Permissions Avoidance by switching Bind to Volume. Without this, you run into a restart loop with this error: https://github.com/Bubka/2FAuth/issues/210 because user 1000:1000 for some reason cant access the folder it is binded to.

azukaar commented 7 months ago

Those files are auto-generated unfortunately you can't edit them like that :/

lilkidsuave commented 7 months ago

Those files are auto-generated unfortunately you can't edit them like that :/

I'm aware. The conversion script also auto fills in the timezone automatically. But for some reason yml binds arent working well unless you make the folder or file chown 1000 or chmod 777 beforehand. Furthermore, the dockerfile enforces 1000:1000 throughout its script, so simply changing the user isn't the end all be all solution. The kinda janky solution is provided here, since you don't need to constantly go in this folder unlike media folders in jellyfin, a volume would be more suitable.

azukaar commented 7 months ago

No no I agree with you that this compose file needs to be updated, but since it is auto-generated, if you edit it the next time the store is updated your changes will be overwritten, that's what I mean What I need to do is provide a way to overwrite changes on specific files or something

lilkidsuave commented 7 months ago

Like a custom tag/flag for the app in question and a checker in the generator?

azukaar commented 7 months ago

yeah or like an override folders with apps that are copied over the generated folder

lilkidsuave commented 7 months ago

Those files are auto-generated unfortunately you can't edit them like that :/

Where does the convert script get called? I don't see it in index or the github workflow

azukaar commented 7 months ago

Manually before push