azukaar / cosmos-servapps-official

Official repository for Cosmos apps on the market
GNU Affero General Public License v3.0
42 stars 42 forks source link

Update Ryot configuration #154

Closed IgnisDa closed 3 months ago

IgnisDa commented 3 months ago

Fixes #153.

IgnisDa commented 3 months ago

@azukaar There also needs to be a TZ env variable set to for example Asia/Kolkata. All other compose files say TZ=auto. Should I use that too and cosmos will automatically set the correct value?

azukaar commented 3 months ago

Thanks a bunch! Looks good. I can merge as soon as you remove the draft status and yes Cosmos automatically replaces "auto" with the user's timezone (assuming it is set on their server)

IgnisDa commented 3 months ago

Does cosmos has the concept of generated variables? There is an env variable ADMIN_ACCESS_TOKEN which should ideally be a secure 32 characters long.

azukaar commented 3 months ago

Yes you have a password generator system, you can do something like that:

https://github.com/azukaar/cosmos-servapps-official/blob/master/servapps/Nextcloud/cosmos-compose.json#L23

Those are 24 characters thought, so you could pad them with 8 additional char in the string if 32 is a requirement

IgnisDa commented 3 months ago

THe 32 characters is not a hard requirement. Can you check if the configuration is fine?

azukaar commented 3 months ago

You're missing one bit, something like this: https://github.com/azukaar/cosmos-servapps-official/blob/master/servapps/Nextcloud/cosmos-compose.json#L30

This allows Cosmos to force persisting env var when reinstalling apps from the market (because you keep the volumes so the tokens need to persist otherwise you lose access to the data on the volume). I am thinking you probably need to persist the admin token? Correct me if Im wrong

Other than that it looks good

IgnisDa commented 3 months ago

Thanks. I fixed it.

On a different note, shouldn't that property be a string array instead?

azukaar commented 3 months ago

On a different note, shouldn't that property be a string array instead?

It's a docker label, it can only be a string

Merged the PR, thanks a lot!