azukaar / cosmos-servapps-official

Official repository for Cosmos apps on the market
GNU Affero General Public License v3.0
41 stars 43 forks source link

Added Homepage #17

Closed erichobson closed 1 year ago

erichobson commented 1 year ago

Also added the (optional) selection to mount docker.sock for Docker integration. If this is something that should be removed, let me know.

erichobson commented 1 year ago

Rather than directly mounting the Docker socket to homepage, I've got it working using the Docker Socket Proxy as seen here. Is this worth adding to this PR, or would it be a better option to not allow connecting to the Docker Socket at all through this configuration?

di5cord20 commented 1 year ago

I agree updating the PR makes sense. This is similar to the PRs I submitted for both Uptime-Kuma and Dozzle (see https://github.com/azukaar/cosmos-servapps-official/pull/22/commits/36614d9e99b7ae61aed589f6396affa0ea2bf6de for an example).

Looking forward to using Homepage.