Closed di5cord20 closed 1 year ago
This is really good design, I am just wondering about something, you ask for socket-proxy-name but you do not actually use it, the socket proxy name is hardoded to socket-proxy Also the socket-proxy container you are creating should container "{ServiceName}" in it's name like "{ServiceName}-socket" so it does not clash with others
The intent was to have 1 single socket proxy container that other apps could connect to (the way I use to do it outside of Cosmos). I understand your suggestion though and have made the update.
Fixed link container issue from previous PR. Should be working now with it’s own socket-proxy.
Could you update this PR to use the same strategy as the Dozzle one? That one was perfect and easy to use for the user thanks :)
Done
Do you still need the warning? I would assume you can just use the DOCKER_HOST variable like you did in Dozzle no?
The warning is more like a reminder on how to add the socket-proxy into Uptime settings to leverage which is a manual step required. I can remove if you'd like, but thought it could be useful for users, especially those who aren't familiar with the process.
As a suggestion, as this project grows, I see more and more people asking for help in the Discord. Many similar questions arise over and over. Perhpas a wiki/documentation that the community could contribute to. There could be a MarketApps section where we can provide instructions to install and configure. So in this case, I'd add a screenshot showing the Uptime Kuma settings and how to update. The warning could either be removed or changed to provide a link to the docs.
What are your thoughts on this idea?
Merged, thanks you :)
UptimeKuma settings has a Docker Hosts section. This enhancement lets the user connect to tcp://socket-proxy:2375 thus allowing the UptimeKuma monitor to watch the container directly in docker.
This commit/enhancement gives user an option to link to socket-proxy container. The compose will ask if a socket-proxy should be used. If yes, will then ask if one already exists.