search

azukaar / cosmos-servapps-official

Official repository for Cosmos apps on the market
GNU Affero General Public License v3.0
41 stars 43 forks source link

Added Prowlarr #23

Closed di5cord20 closed 1 year ago

di5cord20 commented 1 year ago

Currently depends on user to include/select Sonarr container. Not doing so will result in the compose erroring out. This is a known bug due to not having option to add an OR operator in the cosmos-compose.json code.

Update: I have implemented a very ugly bandaid to work around the lack of an OR operator. The good news is that it's a black box to the end user and just works now!

azukaar commented 1 year ago

While this work I had a better idea for this: I will make Cosmos ignore empty strings in the list array of connected container this way you can just link all the variables, and it will just ignore the empty ones I think that will be much easier to maintain this compose file in the future This will be in the next minor release (probably tonight)

di5cord20 commented 1 year ago

Assuming I understood your change correctly, I've removed all of the complex nested if conditions within the links section.

azukaar commented 1 year ago

Cool stuff it works! (and its much cleaner ahah) The only thing is you need to set the minimum version 0.10.3 because this wont work on older version ;) thanks for the good work!

di5cord20 commented 1 year ago

minVersion has been updated

azukaar commented 1 year ago

Thank you!!