azukaar / cosmos-servapps-official

Official repository for Cosmos apps on the market
GNU Affero General Public License v3.0
41 stars 43 forks source link

feat(apps): added sabnzbd #36

Closed Serph91P closed 1 year ago

Serph91P commented 1 year ago

Since NZBget is not developed anymore I thought I upload Sabnzbd.

azukaar commented 1 year ago

Thanks! Asking people to manually change inet_exposure is the wrong approach, because it is too manual and also will still require login. It also will disable the security feature of Sab, which is not a big issue since Cosmos implements its own, but why not keep it on :D The right approach would be to change host_whitelist to include sub.domain.com (https://sabnzbd.org/wiki/extra/hostname-check.html) You can automate this with a post-install script (see Home-Assistant for an example)

If you dont manage to automate it yourself, you could try using this image instead : https://github.com/domibarton/docker-sabnzbd

Which includes an env var instead (HOST_WHITELIST_ENTRIES) which will be much easier for you to integrate

Serph91P commented 1 year ago

Thanks! Asking people to manually change inet_exposure is the wrong approach, because it is too manual and also will still require login. It also will disable the security feature of Sab, which is not a big issue since Cosmos implements its own, but why not keep it on :D The right approach would be to change host_whitelist to include sub.domain.com (https://sabnzbd.org/wiki/extra/hostname-check.html) You can automate this with a post-install script (see Home-Assistant for an example)

If you dont manage to automate it yourself, you could try using this image instead : https://github.com/domibarton/docker-sabnzbd

Which includes an env var instead (HOST_WHITELIST_ENTRIES) which will be much easier for you to integrate

hmm ok will edit the cosmos-compose.json. I think sabnzbd sets a unique id in the host whitelist filed. So i would need to edit the file rather than just downloading one. How would I get the domain from cosmos used for the container?

Serph91P commented 1 year ago

Thanks! Asking people to manually change inet_exposure is the wrong approach, because it is too manual and also will still require login. It also will disable the security feature of Sab, which is not a big issue since Cosmos implements its own, but why not keep it on :D The right approach would be to change host_whitelist to include sub.domain.com (https://sabnzbd.org/wiki/extra/hostname-check.html) You can automate this with a post-install script (see Home-Assistant for an example)

If you dont manage to automate it yourself, you could try using this image instead : https://github.com/domibarton/docker-sabnzbd

Which includes an env var instead (HOST_WHITELIST_ENTRIES) which will be much easier for you to integrate

just checked again, should be easy to replace or rather add to the line. But how can I get from cosmos the url used?

azukaar commented 1 year ago

https://github.com/azukaar/cosmos-servapps-official/blob/master/servapps/Nextcloud/cosmos-compose.json#L20

Serph91P commented 1 year ago

https://github.com/azukaar/cosmos-servapps-official/blob/master/servapps/Nextcloud/cosmos-compose.json#L20

dunno if this will work like I did it because I dont know when those variables are available or not. So if you could take a look if this will work :)

azukaar commented 1 year ago

You dont need to use docker exec there btw it is alraedy inside the container itself

Serph91P commented 1 year ago

You dont need to use docker exec there btw it is alraedy inside the container itself

ok removed it again, but when I import the json the sabnzbd.ini is sadly not edited.

azukaar commented 1 year ago

removed it again, but when I import the json the sabnzbd.ini is

Did it work with docker exec?

Serph91P commented 1 year ago

You dont need to use docker exec there btw it is alraedy inside the container itself

ok removed it again, but when I import the json the sabnzbd.ini is sadly not edited.

removed it again, but when I import the json the sabnzbd.ini is

Did it work with docker exec?

nope sadly not.

Serph91P commented 1 year ago

removed it again, but when I import the json the sabnzbd.ini is

Did it work with docker exec?

is there a way to see the output/log of that so I can check what is not running corectly? because the command used is working fine if I enter the domain manually.

Serph91P commented 1 year ago

Changed everything back to normal config volume and tested the sed command. The sed command is working just fine if run outside of the json. So my guess is that it is not run correctly or something from cosmos side.