azukaar / cosmos-servapps-official

Official repository for Cosmos apps on the market
GNU Affero General Public License v3.0
41 stars 43 forks source link

Fasten Health App Added #94

Closed jeffgallini closed 11 months ago

jeffgallini commented 11 months ago

Early stage app which allows you request records from medical providers and store on your hardware.

I think I did this right. Let me know if the docker compose needs work. I have a couple of other apps that I think would be great.

lilkidsuave commented 11 months ago

No need for the ports section anymore as you are routing using "routes: "

lilkidsuave commented 11 months ago

Target for data should go to /opt/fasten/db according to this https://github.com/fastenhealth/fasten-onprem/blob/main/docker-compose.yml Could also add another volume (type=bind) for a config.yml (also in link above)

lilkidsuave commented 11 months ago

Source for data probably should be named "{ServiceName}-data"

azukaar commented 11 months ago

/docker-compose.yml Could also add another volume (type=bind) for a config.yml (also in link above)

Should be a volume to the folder, otherwise it's going to trip on a bind on a single file

(Thanks for the review!)

jeffgallini commented 11 months ago

Thanks everyone, I'll fix it and add it later today

jeffgallini commented 11 months ago

Since you have the 9090 host port and the 8080 container port, do I need multiple routes for each of them?

"ports":
     "9090:8080"
lilkidsuave commented 11 months ago

No. That one line is just mapping 9090 to 8080. Once you have the route setup for the container port(8080), you don't need that line. On this app, no ports section necessary.

lilkidsuave commented 11 months ago

You could model after other apps that ask for a directory for configs and replace the target/config with {Context.configpath}

lilkidsuave commented 11 months ago

This is going to sound picky(because it is) but double check spacing is correct in volumes(and in general), JSON is picky about spacing.

jeffgallini commented 11 months ago

@azukaar FYI, I just tested it out. The latest version is running when installed via the cosmos-installer. I'm leaving the paths as default for now, if needed, I can try changing them. But it's there if someone wants to make the change.

It should be good to go now.

azukaar commented 11 months ago

Thanks!