search

azukiapp / azk

azk is a lightweight open source development environment orchestration tool. Instantly & safely run any environment on your local machine.
http://azk.io
Apache License 2.0
897 stars 63 forks source link

Loose checking of docker version #527

Closed slobo closed 8 years ago

slobo commented 8 years ago

Helps with distributions that identify themselves in the package name say Fedora 22 docker version: 1.8.1.fc22 Since semver.gte() can throw, it might be good idea to wrap it in try/catch block and either warn and continue or bail ourselves.

nuxlli commented 8 years ago

Good point @slobo, I like the idea of protecting the version check with a block of try/catch.

Did you add that change in PR? Or I can already integrate and you open a new issue for us to prioritize this change?