azukiapp / azk

azk is a lightweight open source development environment orchestration tool. Instantly & safely run any environment on your local machine.
http://azk.io
Apache License 2.0
898 stars 63 forks source link

Make various hipache parameters user configurable #689

Closed slobo closed 7 years ago

slobo commented 7 years ago

We now enable tweaking of various hipache config options via following environment varables:

AZK_BALANCER_WORKERS
AZK_BALANCER_WORKER_MAX_SOCKETS
AZK_BALANCER_TCP_TIMEOUT
AZK_BALANCER_DEAD_BACKEND_TTL

Also increase tcpTimeout to 63 (from 30). 63 is a weird enough number that it should tip of anyone who needs a bigger timeout to search for it and thus easily discover how to increase.

To test this, start the agent with any/all of the above options and corresponding hipache settings should be visible in ~/.azk/data/run/hipache.json. Some, like workers can also be seen to take effect by just looking at number of hipache processes running.

gullitmiranda commented 7 years ago

LGTM

nuxlli commented 7 years ago

Thank you for the PR, @slobo! Nice changes! Could you please add this into the CHANGELOG.md? Then I can merge it next.

slobo commented 7 years ago

Wasn't sure about the wording/tag, let me know if it need me to adjust it further