search

azul3d / engine

Azul3D - A 3D game engine written in Go!
https://azul3d.org
Other
615 stars 52 forks source link

audio/flac,audio/wav: Update to the audio v2 API. #148

Closed mewmew closed 8 years ago

mewmew commented 8 years ago

ref: azul3d/engine#76

mewmew commented 8 years ago

Hi @slimsag,

Glad to see you are also still awake :)

slimsag commented 8 years ago

Haha 5pm here :) Glad to see you weren't angered by my massive (and perhaps quite quick) changes!

This change looks great!

One minor nit though, could you change the commit message for 4a04b18 (the audio/wav change), currently it reads:

audio/flac: Update to the audio v2 API. Drop semver import paths.

to:
audio/wav: Update to the audio v2 API. Drop semver import paths.

So glad once we merge this we can start using it :P

mewmew commented 8 years ago

Done!

slimsag commented 8 years ago

LGTM