search

azul3d / engine

Azul3D - A 3D game engine written in Go!
https://azul3d.org
Other
606 stars 54 forks source link

lmath: mat4 determinant #151

Closed dskinner closed 8 years ago

dskinner commented 8 years ago

Fixes #147

dskinner commented 8 years ago

@slimsag I'm not sure what an appropriate test would be. I looked around and didn't see any existing tests and didn't find anything suitable elsewhere, though maybe digging into glm more or just spending more than a few minutes to think something up would be useful.

I also preserved the name of Determinant for the sake of consistency. If you like it shortened to Det, should probably change all of them. I'm just not sure what all that would affect.

If you have thoughts on a way to directly test, probably some pre-existing table data, let me know and ill add it. Otherwise, I can only guarantee I obsessively traced through the method over 10 times when I initially wrote it.

slimsag commented 8 years ago

Makes sense, I'll look into the testing portion and see what I can come up with later. It probably requires more of an investment for the lmath package than just testing this single function.

:+1: to Determinant that does indeed match the others better. Thanks for catching this!

This is a clear improvement in terms of functionality, so LGTM :) Thank you @dskinner !