soc-pe-bot
commented
2 months ago Team's Response
Thank you for your feedback. However, this is caused by invalid edit of the save file. We have mentioned and emphasized with colors several times that comma is not allowed for comment and it is removed for link command(csv conversion) purpose. This is invalid format and it looks like you were aware of the fact that they are removed as mentioned in your report.
if you edit the save file correctly, things will work; but if you edited it wrongly, there's no guarantee that things will work.
Based on this guideline, this is not a feature flaw.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: While I understand that commas will cause the output csv to behave weirdly when the link command is run, in the User Guide, it only mentions that commas will be removed from the user's input. As such, I thought that this would also disallow the user from manually adding commas should they directly edit the save file (be it intentional or not) by sanitizing the save file on startup.
Additionally, based on the User Guide's Editing the data file section, it states that If your changes to the data file makes its format invalid, HackLink will discard all data and start with an empty data file at the next run. As such, if this is considered an invalid format, it should start from an empty data file, instead of just running as per normal. The only command that could possibly be affected would be the link command.
Lastly, while commas causes problems with csv files, I also think that strictly disallowing commas can be slightly limiting for the users. A simple alternative for this could be to allow commas, but when running link, escape the commas before saving it into the csv.
If I were to write commas in the comment command, it would remove them. However, writing comma directly in the save file would still save and cause errors when running the link command.