azuravian / cbz_jpg-to-webp

Convert cbz files that contain jpg images to webp images.
MIT License
11 stars 2 forks source link

Script fails to convert jpg images #8

Open shinji257 opened 9 months ago

shinji257 commented 9 months ago

As of right now it seems the latest code fails to actually convert any jpg images. The resulting cbz file is lacking any of the files that were jpg. This might skip one image (like the cover or a scanlator added page) or all of them if they were all jpg images. If it doesn't convert or repack the jpg images it can result in a cbz similar to https://github.com/azuravian/cbz_jpg-to-webp/issues/1 where it only contains the ComicInfo.xml metadata file.

The above is on Windows

When testing in Linux it seems to work fine until you go to convert and I get a random file not found error when attempting to do the jpg file in the test cbz file. The temp folder also seems to be created wrong. It creates a folder that shows as \\?\ and has the same hierarchy under it as to the temp folder it mean to create. The temp folder shows that the conversion to webp skipped over jpg images and only converted png images.

azuravian commented 2 months ago

Interesting, it is still working for me. The \?\ gives me a clue though. There is a section where it does a specific path change for windows devices, and that is obviously not working for yours. I'm not sure that it's even needed, so I'll do some research and see if I can fix it.