search

azure-appservice-samples / ContosoMoments

Contoso Moments is a sample to demonstrate the advantages of using Azure App Service for building Modern Applications
https://contosomoments.azurewebsites.net
MIT License
48 stars 92 forks source link

Remove duplicate azuredeploy.json #39

Closed lindydonna closed 8 years ago

lindydonna commented 8 years ago

There's one in the root and in the deployment folder. We should use only one, and have the deployment folder reference the one at the root.

SyntaxC4 commented 8 years ago

@lindydonna This is as designed as we want to make sure that we have a project for the ARM Template as there is some great tooling available to test and modify the templates. The azuredeploy.json is required in the root for the Deploy to Azure button to function.

What I would prefer is to change the task of this to "Add Post Build step to copy ARM template to the repository root"

lindydonna commented 8 years ago

I have a PR that uses the root file in the VS project, and it works fine. I removed the version in the deployment folder. That seems simpler than a post build step, no?

lindydonna commented 8 years ago

Fixed in b40338fb.