search

azure-contrib / socket.io-servicebus

socket.io store which uses Service Bus pub/sub for scale out
Apache License 2.0
30 stars 14 forks source link

Update for socket.io v1.0 #75

Closed calebboyd closed 6 years ago

calebboyd commented 9 years ago

Followed pattern set forth by this adapter: socket.io-redis

glennblock commented 9 years ago

Hi @calebboyd if you want to send this over here, I've forked it. https://github.com/Azure-contrib/socket.io-servicebus

calebboyd commented 9 years ago

@glennblock sure thing!

glennblock commented 9 years ago

Hi @calebboyd

Thanks! Not to be difficult but I am working to get this just transferred over to contrib in which case I'll delete my fork. If that happens, you'll need send another PR :-), also most likely to a diff branch.

I'll keep you posted in the next few days!

Glenn

glennblock commented 9 years ago

Thanks @calebboyd, we'll look into this now that we're in business.

glennblock commented 9 years ago

@calebboyd does this support synchronizing the list of clients? Redis has a DB and does Pub Sub on top. Service Bus is purely message based. When we were implementing the SB Store, we had to handle this by sending messages between to synchronize the lists.

glennblock commented 9 years ago

@calebboyd that was an issue with the chat sample app, not with the store itself.

On that note, did you look at the samples? Those are currently going to break if this PR is accepted. We need the samples to work.

calebboyd commented 9 years ago

Yeah I can take a look at those. Also it looks like a client api was added for cross node client handling in the redis adapter . That will need to be looked at too. I've actually stopped using this in production (worked great when it was there), since azure added redis.

glennblock commented 9 years ago

Glad to hear it worked well for you. Understood on redis.

I appreciate your effort here and your patience!

On Tue, Mar 31, 2015 at 6:44 PM Caleb Boyd notifications@github.com wrote:

Yeah I can take a look at those. Also it looks like a client api was added for cross node client handling in the redis adapter https://github.com/Automattic/socket.io-redis/blob/master/index.js#L150 . That will need to be looked at too. I've actually stopped using this in production (worked great when it was there), since azure added redis.

— Reply to this email directly or view it on GitHub https://github.com/azure-contrib/socket.io-servicebus/pull/75#issuecomment-88307826 .

shijuvar commented 9 years ago

This is really good thing that some updates are happening on this repository.

glennblock commented 9 years ago

An on that note...I just realized Travis CI needs to get fixed.