search

azureautomation / automation-packs

Collections of Automation resources that can include runbooks, configurations, modules, credentials, schedules, variables, connections, certificates, jobs, compilation jobs, and nodes.
MIT License
75 stars 42 forks source link

Several updates to deployThroughARM.ps1 #4

Closed pcgeek86 closed 8 years ago

pcgeek86 commented 8 years ago
  1. Updated string literals to use single quotes as best practice, to avoid accidental interpolation.
  2. Removed unnecessary quotes around HashTable keys.
  3. Added more relevant names to Resource Group and Automation Account names.

Cheers, Trevor Sullivan Microsoft MVP: PowerShell

jodoglevy commented 8 years ago

Hey @elcooper, in the future can you check with the owner before merging? This all looks fine except I don't like the new names of the resource group and automation account that are created. More than just AA DSC resources are created -- this is meant to be a sample environment for all Azure Automation features.

Trevor can you do another pull request where they're named "SampleAutomationAccount" and "SampleAutomationResourceGroup" or similar?

elcooper commented 8 years ago

Sure thing. Sorry about that Joe!

From: Joe Levy [mailto:notifications@github.com] Sent: Monday, November 23, 2015 1:05 PM To: azureautomation/automation-packs automation-packs@noreply.github.com Cc: Beth Cooper elcooper@microsoft.com Subject: Re: [automation-packs] Several updates to deployThroughARM.ps1 (#4)

Hey @elcooperhttps://github.com/elcooper, in the future can you check with the owner before merging? This all looks fine except I don't like the new names of the resource group and automation account that are created. More than just AA DSC resources are created -- this is meant to be a sample environment for all Azure Automation features.

Trevor can you do another pull request where they're named "SampleAutomationAccount" and "SampleAutomationResourceGroup" or similar?

— Reply to this email directly or view it on GitHubhttps://github.com/azureautomation/automation-packs/pull/4#issuecomment-159063879.

pcgeek86 commented 8 years ago

@jodoglevy Joe, I just went to update this, but it look like you already have done so yesterday.

https://github.com/azureautomation/automation-packs/commit/3d358e1eb038ea9a293ed39b37d3c2f97fa96c33#diff-f1bbc499447edc8b9c3620ba2a1d404e

/cc @elcooper

Cheers, Trevor Sullivan Microsoft MVP: PowerShell

jodoglevy commented 8 years ago

Yup sorry forgot to update this thread On Nov 25, 2015 6:13 PM, "Trevor Sullivan" notifications@github.com wrote:

@jodoglevy https://github.com/jodoglevy Joe, I just went to update this, but it look like you already have done so yesterday.

3d358e1#diff-f1bbc499447edc8b9c3620ba2a1d404e https://github.com/azureautomation/automation-packs/commit/3d358e1eb038ea9a293ed39b37d3c2f97fa96c33#diff-f1bbc499447edc8b9c3620ba2a1d404e

/cc @elcooper https://github.com/elcooper

Cheers, Trevor Sullivan Microsoft MVP: PowerShell

— Reply to this email directly or view it on GitHub https://github.com/azureautomation/automation-packs/pull/4#issuecomment-159782063 .