search

azurecurve / azrcrv-gallery-from-folder

Gallery From Folder plugin for ClassicPress
GNU General Public License v2.0
0 stars 1 forks source link

Restructure or document #4

Open joyously opened 4 years ago

joyously commented 4 years ago

This plugin makes no sense, and it doesn't explain what it needs, as it is. As far as I can tell from the code, it is limited to using one folder under the wordpress installation folder, it has to have a subfolder named 'thumbnails', and it has to have the thumbnails existing with the same names as the images. The output is a simple link to an image, with no other markup and no classes and no captions (like filenames). There is no attempt to have similar classes to the standard gallery, so that the theme's CSS could kick in.

Since it's a shortcode, why must there be an options page? Why limit it to one folder? Why would anyone want to name their folder the same as the post slug, and what happens if that is edited? Why check for thumbnails, instead of generating them?

I have looked for this functionality, for a client site. One is a plant nursery, and they wanted to show a garden tour, and be able to simply upload the photos to the folder and do nothing more. They don't even have an account to log in, but with a WebDAV folder that can be easily done.

If you do no code changes, at least document better what your plugin does, and its limitations.

azurecurve commented 4 years ago

I created this plugin as I wanted a simple gallery display which read images from folder; part of creating it was that I don;t like the standard gallery so I didn't look to copy any of it.

There is a base folder which would hold one folder per gallery, with each of these galleries containing a thumbnail folder.

I'm rewriting parts of it, including settings, based on the issues you've raised to make it more useful to others.

I did look at generating the thumbnails, but after several methods I gave up as they all produced file sizes much larger than the original image.

joyously commented 4 years ago

I did look at generating the thumbnails, but after several methods I gave up as they all produced file sizes much larger than the original image.

I suppose that's what people complain about the core functions that generate the other image sizes?

part of creating it was that I don;t like the standard gallery so I didn't look to copy any of it.

Yes, I understand, but your markup has almost nothing to use to style it. And the gallery markup is not bad when using the html5 mode. It is easily styled, and every theme already does.

azurecurve commented 4 years ago

I can take a look at the standard gallery markup and see what I think about using it.

I'll also take another look at the image resize and see if it was me of the functions as it would be nice to not have to do the resize myself before uploading.