search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.05k stars 155 forks source link

easter sunday and pentecost sunday are not nationwide german holidays #100

Closed TalonTR closed 6 years ago

TalonTR commented 6 years ago

They are holidays only in Brandenburg, see https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland#%C3%9Cbersicht_aller_gesetzlichen_Feiertage

stelgenhof commented 6 years ago

Thanks for the PR!

The source for defining the German Public Holidays was mainly Wikipedia: https://en.wikipedia.org/wiki/Public_holidays_in_Germany. This page list Easter Sunday and Pentecost as celebrated in all states. Comparing it with your source, this one is then incorrect?

Cheers! Sacha

crossan007 commented 6 years ago

I just discovered that Easter does not show up in the 'USA' provider as well.

stelgenhof commented 6 years ago

@crossan007 It's correct it is not included as currently the USA provider focuses on Federal Holidays only. Of course, non-federal/other holidays can be added as well :)

Cheers! Sacha

TalonTR commented 6 years ago

The table from your referenced english Wikipedia page doesn't list Pentecost Sunday and Easter Sunday for any German state. Below the table it states:

In addition the state of Brandenburg has formally declared Easter Sunday and Pentecost Sunday as public holidays. As these are Sundays anyway, they have been left away by the other states, nor counted in the table above (the state of Hesse even declared all Sundays public holidays)."

This is exactly the same as within the german Wikipedia.

These dates are celebrated nationwide, but are not considered holidays in most states.

stelgenhof commented 6 years ago

@TalonTR Perfect! I must have overlooked that.

TalonTR commented 6 years ago

Didn't i already do that? All German Easter Sunday and Pentecost Sunday Tests are modified.

TalonTR commented 6 years ago

Done :)