search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Provider for Mexico #143

Closed gogl92 closed 4 years ago

gogl92 commented 5 years ago

Creating the provider for Mexico is not too difficult except for the holidays that are adjusted to the closest monday.

stelgenhof commented 5 years ago

Thanks! Is this issue just a request or are you planning on contributing the provider for Mexico?

Having holidays that are observed to the next Monday in case a national holiday is not difficult. You can see the code of other holiday providers how it is done.

Cheers! Sacha

gogl92 commented 5 years ago

I will try to make the contribution and create the pull request.

stelgenhof commented 5 years ago

@gogl92 Cool! Let me know if you have any questions. Best is to use one of the existing countries as a starting point. FIY, your PR needs to be made against the develop branch :)

Cheers! Sacha

stelgenhof commented 4 years ago

@gogl92 Wanted to check if you have made any progress with the Mexico provider. If not and you don’t have any time, I can take it over if you like

github-actions[bot] commented 4 years ago

This issue has been open 30 days with no activity. Please remove the stale label or comment, or this will be closed in 5 days